Skip to content

Conversation

@rjan90
Copy link
Contributor

@rjan90 rjan90 commented Oct 15, 2025

#416

Create base skeleton for nv28

chore: duplicate v17 to v18
chore: update references to v18 from v17 in builtin/v18
chore: create base nv28-skeleton
chore: update simple migration
@rjan90 rjan90 requested a review from TippyFlitsUK October 15, 2025 07:16
@rjan90 rjan90 self-assigned this Oct 15, 2025
Copilot AI review requested due to automatic review settings October 15, 2025 07:16
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Oct 15, 2025
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Oct 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request creates the base skeleton for network version 28 (nv28) by adding the foundation structure for version 18 builtin actors and supporting infrastructure.

Key changes include:

  • Established the builtin/18 package structure with core actor implementations
  • Added utility packages for ADT (Abstract Data Types) and mathematical operations
  • Implemented system migration infrastructure for nv28

Reviewed Changes

Copilot reviewed 89 out of 112 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
builtin/18/util/adt/balancetable.go Balance table implementation for token amount management
builtin/18/util/adt/array.go Array data structure for AMT-based storage operations
builtin/18/system/ System actor implementation with state management and CBOR serialization
builtin/18/reward/ Reward actor with state, logic, and economic calculations
builtin/18/power/ Power actor for storage power tracking and miner consensus
builtin/18/paych/ Payment channel actor for off-chain microtransactions
builtin/18/multisig/ Multisig actor for multi-signature wallet functionality
builtin/18/miner/ Miner actor with comprehensive sector management and economics
builtin/18/migration/system.go Migration logic for transitioning system actor to v18
builtin/18/ethaccount/types.go Ethereum account integration types
builtin/18/cron/cron_types.go Cron scheduler types for periodic tasks
builtin/18/placeholder/methods.go Placeholder actor with no methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

chore: update folder name builtin/18 to builtin/v18
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 1.97843% with 10999 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.64%. Comparing base (e57db7c) to head (6b8e54b).

Files with missing lines Patch % Lines
builtin/v18/market/cbor_gen.go 0.00% 1990 Missing ⚠️
builtin/v18/multisig/cbor_gen.go 0.00% 1243 Missing ⚠️
builtin/v18/power/cbor_gen.go 2.78% 1097 Missing and 20 partials ⚠️
builtin/v18/datacap/cbor_gen.go 0.00% 978 Missing ⚠️
builtin/v18/miner/invariants.go 0.00% 745 Missing ⚠️
builtin/v18/paych/cbor_gen.go 0.00% 676 Missing ⚠️
builtin/v18/evm/cbor_gen.go 0.00% 526 Missing ⚠️
builtin/v18/eam/cbor_gen.go 0.00% 412 Missing ⚠️
builtin/v18/init/cbor_gen.go 0.00% 319 Missing ⚠️
builtin/v18/check.go 0.00% 303 Missing ⚠️
... and 43 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage    3.60%    3.64%   +0.04%     
==========================================
  Files         733      802      +69     
  Lines      200238   221763   +21525     
==========================================
+ Hits         7212     8094     +882     
- Misses     190759   211101   +20342     
- Partials     2267     2568     +301     
Files with missing lines Coverage Δ
builtin/v18/miner/cbor_gen.go 4.94% <ø> (ø)
builtin/v18/util/adt/map.go 20.32% <ø> (ø)
builtin/v18/util/adt/multimap.go 0.00% <ø> (ø)
builtin/v18/util/adt/set.go 0.00% <ø> (ø)
builtin/v18/util/adt/store.go 100.00% <ø> (ø)
builtin/v18/util/bitfield.go 0.00% <ø> (ø)
builtin/v18/util/bitfield_queue.go 0.00% <ø> (ø)
builtin/v18/util/math/expneg.go 80.95% <ø> (ø)
builtin/v18/util/math/ln.go 100.00% <ø> (ø)
builtin/v18/util/math/parse.go 75.00% <ø> (ø)
... and 60 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Oct 15, 2025
@rjan90 rjan90 merged commit df361f5 into master Oct 15, 2025
8 checks passed
@rjan90 rjan90 deleted the phi/nv28-skeleton branch October 15, 2025 12:02
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants